feat: expose plan_seats and plan_filled_seats on github_organization data source#3451
Open
zry98 wants to merge 1 commit into
Open
feat: expose plan_seats and plan_filled_seats on github_organization data source#3451zry98 wants to merge 1 commit into
plan_seats and plan_filled_seats on github_organization data source#3451zry98 wants to merge 1 commit into
Conversation
…tion` data source
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3452
Before the change?
The
github_organizationdata source exposes only aplan(the plan name as a string), available seats (plan.seats) and current filled seats (plan.filled_seats) are not exposed as attributes, although they are available from GitHub API'sGET /orgs/{org}endpoint as documented here.When managing organization membership with this provider, there is no way to detect when the org's seats are full when running
terraform plan, butterraform applywill fail withYou must purchase at least one more seat to add this user as a member. [{Resource: Field:user Code:no_seat Message:}], requiring an organization/enterprise owner to manually add seats before rerunning the apply.After the change?
Two new computed integer attributes are added to the
github_organizationdata source:plan_seats: The total number of seats included in the organization's plan.0if the plan does not have a seat limit (e.g.freeplan)plan_filled_seats: The number of seats currently filled in the organization's planBoth are populated from the existing
Organizations.Getcall, no additional API request, and the existingplanstring attribute is untouched, so this is non-breaking.Provider users can now gate membership changes via lifecycle precondition, e.g.:
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!